feat: claude citation support with BedrockModel #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
changed the title
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Unshure
reviewed
Aug 11, 2025
| @@ -24,10 +24,11 @@ | |||
| from mcp.types import ImageContent as MCPImageContent | |||
| from mcp.types import TextContent as MCPTextContent | |||
|
|
|||
| from strands.types.tools import ToolResultContent, ToolResultStatus | |||
There was a problem hiding this comment.
Why relative to absolute import?
There was a problem hiding this comment.
Mypy was complaining without it
| if "citationsContent" not in state: | ||
| state["citationsContent"] = [] | ||
|
|
||
| state["citationsContent"].append(delta_content["citation"]) |
There was a problem hiding this comment.
Instead of just appending the response to a list, I can see that the CitationSourceContentDelta event mentions that it contains "incremental updates to the source content text during streaming responses". Does this mean we are concatenating the strings of the CitationSourceContentDelta events, or just appending the events to an array?
| @@ -206,6 +214,18 @@ def handle_content_block_stop(state: dict[str, Any]) -> dict[str, Any]: | |||
| ) | |||
| state["reasoningText"] = "" | |||
|
|
|||
| # Handle citations_content independently - not as elif since we can have both text and citations | |||
| if citations_content: | |||
Co-authored-by: Nick Clegg <[email protected]>
theagenticguy
requested a deployment
to
manual-approval
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for citations when using Anthropic Claude Sonnet 3.5v2 and above
Related Issues
#570
Documentation PR
Type of Change
New feature
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.